Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'ModbusTcpClient' object has no attribute 'handle_local_echo' if client != ModbusSerialClient #494

Closed
wildstray opened this issue Feb 14, 2020 · 2 comments
Closed

'ModbusTcpClient' object has no attribute 'handle_local_echo' if client != ModbusSerialClient #494

wildstray opened this issue Feb 14, 2020 · 2 comments
Labels
Bug

Comments

@wildstray
Copy link
Contributor

Branch: dev

File "/home/andrea/LWE/MPO/Myna/wolf/pymodbus/transaction.py", line 242, in _transact
if self.client.handle_local_echo is True:
AttributeError: 'ModbusTcpClient' object has no attribute 'handle_local_echo'

Suggested fix:

if getattr(self.client, 'handle_local_echo', False) is True:

Instead of:

if self.client.handle_local_echo is True:
@gcbirzan
Copy link 

if getattr(self.client, 'handle_local_echo'):

Is the pythonic way of doing that.

dhoomakethu added a commit that referenced this issue Jul 3, 2020
@dhoomakethu
1. update requirements
e402d9f 
2. Fix examples
3. Fix #494 - handle_local_echo
4. Fix #500 -- asyncio serial client with already running loop
5. Fix #486 - Pass serial args for asyncio serial client
6. Fix #490 - Typo in decode_data for socker_framer
7. Fix #385 - Support timeouts to break out of responspe await when server goes offline
8. Misc updates
@dhoomakethu
Copy link
Contributor

Fixed with e402d9f#diff-40a48d0b5cf576d37ccece3543183f65R242
Please give a try with this branch https://github.com/riptideio/pymodbus/tree/asyncio-bug-fixes

@dhoomakethu dhoomakethu added this to the 3.0.0 milestone Jul 4, 2020
dhoomakethu added a commit that referenced this issue Aug 1, 2020
@dhoomakethu
Asyncio bug fixes (#517)
83e5734 
* Closes  #491

* 1. update requirements
2. Fix examples
3. Fix #494 - handle_local_echo
4. Fix #500 -- asyncio serial client with already running loop
5. Fix #486 - Pass serial args for asyncio serial client
6. Fix #490 - Typo in decode_data for socker_framer
7. Fix #385 - Support timeouts to break out of responspe await when server goes offline
8. Misc updates

* #516 custom data block fix
dhoomakethu added a commit that referenced this issue Sep 11, 2020
@dhoomakethu
#515 fix repl broadcast (#531)
29f694c 
* 1. update requirements
2. Fix examples
3. Fix #494 - handle_local_echo
4. Fix #500 -- asyncio serial client with already running loop
5. Fix #486 - Pass serial args for asyncio serial client
6. Fix #490 - Typo in decode_data for socker_framer
7. Fix #385 - Support timeouts to break out of responspe await when server goes offline
8. Misc updates

* #516 custom data block fix

* Fix broadcast error  with REPL client #515

* Fix #509 Wrong unit ID referenced in framers

* Update documentation for serial forwarder example. Fixes #525

* Fix unit tests, support python 3.8 for tests, renamed:    pymodbus/server/asyncio.py -> pymodbus/server/async_io.py and pymodbus/client/asynchronous/asyncio -> pymodbus/client/asynchronous/async_io

* Ignore python3 code syntax while reporting coverage

* Fix tests failing on python 3.6 and osx

* Fix typo in makefile

* Fix test execution errors specific to python3.6

* Osx travis issue - Fix trial 1

* Travis reverting xcode to 8.x for mac osx
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gcbirzan @wildstray @dhoomakethu