Python3 #187
Closed
Python3 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding a python 2x/3x compatibility layer - adding tox testing and setup.py command - converting all strings to bytes in tests and code - common porting the code examples - abstracting ord/chr differences with compatibility layer - converting struct.(un)pack(B) to compatibility layer - converting payload to use to_string (breaking) - updating configuration values - updating deep_clean to work with python3
- bumping dependency versions - using examples to explore python3 bugs - checking that the example code works under python3
- converting contrib code to python3 - fixing binary protocol - fixing ascii protocol - fixing documentation issues - all tests pass for python3
Endian should be switchable, Endian in the fromRegisters function always was Endian.Big (>) This is correctly implemented in the master branch.
FIX: Ability to chose Endianness in fromRegisters function
* Remerge of changes in clean feature branch. * Excluded async tests due to twisted dependencies in imports. Adapted synchronous tests to new standard socket library by adding more required mocks. * Removed twisted dependency.
|
@moltob I will try to resolve these conflicts and will add you as reviewer . Please confirm if the resolve still holds good. |
* Add connected property to AsyncModbusClientMixin. * Add check against setting result and future that is alreadt done/cancelled
dhoomakethu
added a commit
that referenced
this pull request
Dec 18, 2017
dhoomakethu
added a commit
that referenced
this pull request
Dec 18, 2017
2. Updated examples and tests 3. Move to py.test from nosetests 4. Set coverage failure to 85% till all asyncio unit tests are covered
dhoomakethu
added a commit
that referenced
this pull request
Dec 18, 2017
2. Updated examples and tests 3. Move to py.test from nosetests 4. Set coverage failure to 85% till all asyncio unit tests are covered
|
Will be covered as part of #246 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up mess.