Add connected property to AsyncModbusClientMixin. #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pymodbus
with pyserial-asyncio ther is problem when calling protocol right after creation pair of transport an protocol.On transport initialization
protocol.connection_made
callback is being added vialoop.call_soon
so that this example works becauseclient.read_coils
is called from coroutine (after several event loop iterations).When I use it like this:
I am getting error
'NoneType' object has no attribute 'write'
because transport is not assigned yet to protocol.connected
property allows for such workaround:Maybe transport should be responsible for awaiting
connection_made
inside initializer?