Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for #1662 #1663

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

fhydralisk
Copy link
Contributor

@fhydralisk fhydralisk commented Jul 18, 2023

Add a **kwargs init argument in ModbusTCPServer.

Also with unit test code added for this.

fixes #1662

@fhydralisk fhydralisk force-pushed the patch-modbustcpserver branch from fb743ec to 6b93d92 Compare July 18, 2023 03:07
pymodbus/server/async_io.py Outdated Show resolved Hide resolved
test/test_simulator.py Show resolved Hide resolved
@fhydralisk fhydralisk requested a review from janiversen July 18, 2023 07:36
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

Looking forward to see more PRs from you.

@janiversen janiversen merged commit bc26449 into pymodbus-dev:dev Jul 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulator server cannot start in current dev branch
2 participants