Bug fix for #1662

pymodbus-dev · Jul 18, 2023 · 6b93d92 · 6b93d92
1 parent 9c425aa
commit 6b93d92
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/pymodbus/server/async_io.py b/pymodbus/server/async_io.py
@@ -269,6 +269,7 @@ def __init__(
         broadcast_enable=False,
         response_manipulator=None,
         request_tracer=None,
+        **kwargs,  # pylint: disable=unused-argument
     ):
         """Initialize the socket server.
 

diff --git a/test/test_simulator.py b/test/test_simulator.py
@@ -1,10 +1,13 @@
 """Test datastore."""
 import copy
+import json
+from unittest.mock import mock_open, patch
 
 import pytest
 
 from pymodbus.datastore import ModbusSimulatorContext
 from pymodbus.datastore.simulator import Cell, CellType, Label
+from pymodbus.server import ModbusSimulatorServer
 
 
 FX_READ_BIT = 1
@@ -94,6 +97,24 @@ class TestSimulator:
         "repeat": [{"addr": [0, 48], "to": [49, 147]}],
     }
 
+    default_server_config = {
+        "server": {
+            "comm": "tcp",
+            "host": "0.0.0.0",
+            "port": 5020,
+            "ignore_missing_slaves": False,
+            "framer": "socket",
+            "identity": {
+                "VendorName": "pymodbus",
+                "ProductCode": "PM",
+                "VendorUrl": "https://github.com/pymodbus-dev/pymodbus/",
+                "ProductName": "pymodbus Server",
+                "ModelName": "pymodbus Server",
+                "MajorMinorRevision": "3.1.0",
+            },
+        },
+    }
+
     test_registers = [
         Cell(),
         Cell(),
@@ -539,3 +560,18 @@ def test_simulator_action_random(self, celltype, minval, maxval):
                     regs, is_int
                 )
             assert minval <= new_value <= maxval
+
+    async def test_init_simulator(self):
+        """Test init simulator server"""
+        with patch(
+            "builtins.open",
+            mock_open(
+                read_data=json.dumps(
+                    {
+                        "server_list": self.default_server_config,
+                        "device_list": {"device": self.default_config},
+                    }
+                )
+            ),
+        ):
+            ModbusSimulatorServer()