Set different almost equal tolerance depending on floatX #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken test we are seeing in #3977, #3978 and #3979. I just changed the assertion decimal tolerance depending on theano's floatX.
Depending on what your PR does, here are a few things you might want to address in the description:
what are the (breaking) changes that this PR makes?
None
important background, or details about the implementation
None
are the changes—especially new features—covered by tests and docstrings?
No
consider adding/updating relevant example notebooks
No
right before it's ready to merge, mention the PR in the RELEASE-NOTES.md
It's an infrastructure fix so it doesn't need to go into the release notes