-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple test case for coords behavior #3977
Conversation
Can someone confirm that Travis will pick up a test like this? It's not obvious whether the test harness only includes a select subset on travis, or whether all additions will get picked up by default. |
OK, looks like my new test is running and failing, now I just need to wait for the error message to print out.
|
Boom:
|
I suspect this will be fixed by the next arviz release? Anyone know for sure? |
I think this is the arviz PR that needs to be present for pymc3 <> arviz coords behavor to work: arviz-devs/arviz#1228 |
I've added to this PR a version bump on Arviz that ensures the correct version in the pymc3 requirements. This is ready for review and merge. The only test failure is an unrelated failure on text_matrix_multiply. |
Pinging @michaelosthege as it would be great to bump the bug fix version of pymc3 (move it to 3.9.2) to ensure an upgrade of pymc3 will also upgrade to the proper arviz version. |
This PR adds a simple test case that attempts to trigger issue #3976. I'm mainly checking to see whether the current CI/CD reproduces the issue I'm seeing. I've also bumped the minimum version of arviz to ensure correct behavior of coords.