-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-run notebooks that don't need human attention #266
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:11Z We need to change one of the scripts I think so that the pymc3 tags do not get added, I did that with a replace also inside of .py files. |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:12Z The deep learning link won't work. |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:13Z Also has deeplearning.net links. michaelosthege commented on 2022-01-09T15:57:31Z True, but out of scope. Broken Hyperlinks on Website · Issue #165 · pymc-devs/pymc-examples (github.com) |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:13Z That didn't work. michaelosthege commented on 2022-01-09T15:54:30Z I have no idea why it was committed then. It must have had a 0 exit code. |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:15Z Maybe use michaelosthege commented on 2022-01-09T16:01:11Z
Expecting that we'll have to do more automated re-runs in the near future, I'd like to prioritize determining which notebooks (don't) need manual inspection.. |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:17Z pm.ConstantData() |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:18Z pm.ConstantData |
View / edit / reply to this conversation on ReviewNB twiecki commented on 2022-01-09T15:39:18Z pm.ConstantData() |
I have no idea why it was committed then. It must have had a 0 exit code. View entire conversation on ReviewNB |
True, but out of scope. Broken Hyperlinks on Website · Issue #165 · pymc-devs/pymc-examples (github.com) View entire conversation on ReviewNB |
Expecting that we'll have to do more automated re-runs in the near future, I'd like to prioritize determining which notebooks (don't) need manual inspection.. View entire conversation on ReviewNB |
c8bc3bf
to
b75c287
Compare
Ready for review. |
will merge in a few minutes after merging some other PRs and releasing a snapshot |
Many also failed because I didn't have Bambi installed. Let's make a list of what we need to do manually - some of that might be candidates for the migration script, or for reversing unnecessary breaks at the API level. |
I'm using the following script, located in
pymc-examples/scripts
and accompanied bytodo.txt
,error.txt
andsuccess.txt
.The
todo.txt
has a line with the absolute path to each notebook for which there is currently no other open pull request.