-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Hyperlinks on Website #165
Comments
Thanks! I have added a note on this at https://github.com/pymc-devs/pymc-examples/wiki/Notebook-updates-overview. You mention a dead link checker, do you know if it could be added as a step to our CI? It currently checks format, execution order and a couple other things and it would be great to also check that. Especially given that sometimes reviewnb doesn't render the links correctly. i.e. the link may not work for me when reviewing even when the link does work locally and once rendered on the website. |
@OriolAbril I had just used https://www.deadlinkchecker.com, which seems a little stochastic and not practically useful here. Would you want to use something in pre-commit and/or a github action? |
I found pytest-check-links which works on:
One consideration is if you want to check the source files for broken links, or check resulting files/website itself |
I think checking the source files is fine, maybe even better. There will be links that are sphinx generated and therefore won't be checked in this approach, but these rely on intersphinx which should be quite robust and error out when building the docs if there is an issue. |
Maybe pytest-check-links is worth checking out then. Depending on how long it takes, it can be done by CI for PR, etc |
I don't know if this deserves a (separate) issue, since its very minor. Yet, I want to mention it at least. |
Thanks, it looks like we should update the target and reference to be both lowercase only as the issue is a bit old already and doesn't look active. Do you want to send the PRs for this? The target is defined in https://github.com/pymc-devs/pymc/blob/main/docs/source/learn/core_notebooks/GLM_linear.ipynb (top of the file) |
I ran https://docs.pymc.io/ through a dead link checker and found a number of broken links on the website. Some should be fixed from the
pymc-examples
repo and some are in the mainpymc3
repo, so I'm posting in both. Some hyperlinks just need to be updated (and images to bayesian book covers), but others may point to entities or resources that don't exist anymore.This doesn't seem to be exhaustive because the link from the GLM Logistic Regression by @springcoil and @jbencook to @jbencook 's original blog post is definitely broken
The text was updated successfully, but these errors were encountered: