-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a false negative for --ignore-patterns
#9630
Merged
jacobtylerwalls
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:9273_ignore_patterns_ignores_too_much
May 16, 2024
Merged
Fix a false negative for --ignore-patterns
#9630
jacobtylerwalls
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:9273_ignore_patterns_ignores_too_much
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦be linted is specified using a dot(``.``) and all files are ignored instead of only the files whose name begin with a dot. Closes pylint-dev#9273
mbyrnepr2
added
the
False Negative π¦
No message is emitted but something is wrong with the code
label
May 15, 2024
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9630 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 174 174
Lines 18889 18890 +1
=======================================
+ Hits 18103 18104 +1
Misses 786 786
|
This comment has been minimized.
This comment has been minimized.
Thanks, Mark. I think we can backport this as a bugfix, as it's not really a message behavior change. |
jacobtylerwalls
added
Bug πͺ²
backport maintenance/3.3.x
and removed
False Negative π¦
No message is emitted but something is wrong with the code
labels
May 16, 2024
jacobtylerwalls
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jacobtylerwalls
pushed a commit
that referenced
this pull request
May 16, 2024
* Fix a false negative for ``--ignore-patterns`` when the directory to be linted is specified using a dot(``.``) and all files are ignored instead of only the files whose name begin with a dot. Closes #9273 (cherry picked from commit b3aceb0) Co-authored-by: Mark Byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false negative for
--ignore-patterns
when the directory to be linted is specified using a dot(.
) and all files are ignored instead of only the files whose name begin with a dot.Closes #9273