Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using local copy of pylint.testutils if import fails #98

Closed
wants to merge 2 commits into from
Closed

Using local copy of pylint.testutils if import fails #98

wants to merge 2 commits into from

Conversation

jmaroeder
Copy link
Contributor

Fixes #97

PyLint removed/made private many of the methods that were being used to generate tests. This PR addresses that by including a local copy of pylint's testutils.py and falling back to that.

See discussion here: pylint-dev/pylint#1438

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage remained the same at 87.692% when pulling ae03400 on jamesmallen:fix/make-tests into f0655cc on landscapeio:master.

atodorov added a commit to MrSenko/django-pylint that referenced this pull request Jan 16, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
pylint-dev#107 and
pylint-dev#97

Obsoletes
pylint-dev#98
atodorov added a commit to MrSenko/django-pylint that referenced this pull request Jan 16, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
pylint-dev#107 and
pylint-dev#97

Obsoletes
pylint-dev#98
atodorov added a commit to MrSenko/django-pylint that referenced this pull request Jan 16, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
pylint-dev#107 and
pylint-dev#97

Obsoletes
pylint-dev#98
atodorov added a commit to MrSenko/django-pylint that referenced this pull request Jan 17, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
pylint-dev#107 and
pylint-dev#97

Obsoletes
pylint-dev#98
atodorov added a commit to MrSenko/django-pylint that referenced this pull request Jan 18, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
pylint-dev#107 and
pylint-dev#97

Obsoletes
pylint-dev#98
atodorov added a commit that referenced this pull request Jan 18, 2018
this mimics more closely what pylint does for their own tests
and doesn't rely on deprecated functionality. Fixes
#107 and
#97

Obsoletes
#98
@atodorov
Copy link
Contributor

Merged manually as part of #113, thanks.

@atodorov atodorov closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants