Merge updated fork #113

atodorov · 2018-01-18T09:35:31Z

Changes:

make tests running again
remove testing for Python 2 and older versions of Django (testing only with 1.11 and 2.0+ on Py3). No modifications to the code though, should still work on older versions.
merged all other pending PRs, keeping authorship credentials so we can merge directly instead of going over each PR individually.

TODO: will remove custom naming and versioning coming from the fork and let you know when this is ready to merge and review.

coveralls · 2018-01-18T09:37:09Z

Coverage decreased (-2.9%) to 84.774% when pulling 2e058dc on MrSenko:merge_fork into f0655cc on landscapeio:master.

coveralls · 2018-01-18T09:50:20Z

Coverage decreased (-2.9%) to 84.774% when pulling f958844 on MrSenko:merge_fork into f0655cc on landscapeio:master.

this mimics more closely what pylint does for their own tests and doesn't rely on deprecated functionality. Fixes pylint-dev#107 and pylint-dev#97 Obsoletes pylint-dev#98

since we're testing with latest Django versions this is now required for all ForeignKey fields

the plugin should be able to suppress these kinds of errors for model classes and also for Meta classes so no need to disable them explicitly.

also remove couple of suppressions b/c these class checks are already handled by the check for meta class and they don't seem to have any effect

this was previously skipped but since we don't test on older versions we can explicitly add it again.

the latest version of pylint expects the error messages in slightly different format.

for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111

Added suppressions for [DjangoModelFactory](http://factoryboy.readthedocs.io/en/2.9.2/orms.html#the-djangomodelfactory-subclass). Original PR: pylint-dev#103

Checks that Pylint does not complain about django lazy proxy when using ugettext_lazy

Fix E1101:Instance of '__proxy__' has no 'format' member' when using .format() on a ugettext_lazy translation NOTE: merged with modifications. Instead of returning str, returns '' Fixes pylint-dev#80 Origina PR: pylint-dev#100

Original PR: pylint-dev#99 Fixes pylint-dev#95

Original PR: pylint-dev#92

NOTE: merged with modifications: - resolved conflicts - updated where test files are on disk Original PR: pylint-dev#84

coveralls · 2018-01-18T09:54:05Z

Coverage decreased (-2.9%) to 84.774% when pulling ae6351d on MrSenko:merge_fork into f0655cc on landscapeio:master.

coveralls · 2018-01-18T09:55:51Z

Coverage decreased (-2.9%) to 84.774% when pulling f6a5ac2 on MrSenko:merge_fork into f0655cc on landscapeio:master.

carlio · 2018-01-18T10:11:47Z

This all looks good to me!

Two comments - first, makes sense to wait for @colinhowe to have a look and also see what his changes are, may as well merge at the same time.

Second - it'd probably be good to have some kind of deprecation or warning maybe in setup.py that Py2 is not supported, as lots of people don't install a specific version so will get the latest and suddenly builds break (trust me on that one!). Does that make sense? Maybe just a sysexit with a printed line saying "if you want to use py2 with pylint-django please install a version <0.8". With better wording.

atodorov · 2018-01-18T10:15:11Z

@carlio I can add the deprecation warning in a separate commit before we release 0.8. I have only removed testing for Python 2, mostly because I didn't have the time to deal with fixing the Python 2 tests. I have not modified the code to remove anything related to Py2 so everything will still work.

And we can make version 0.8.0 the last that will support Py2, then declare this project Py3 only and move on.

carlio · 2018-01-18T10:23:53Z

because I didn't have the time to deal with fixing the Python 2

Oh I understand that completely!

Sounds all good to me.

colinhowe · 2018-01-18T13:49:00Z

I'm happy with all of this. My changes have made it in already via the work that @atodorov has done

carlio · 2018-01-18T14:16:24Z

Let's do it! I'll let you push the button to make sure permissions are set up right, let me know if there are any problems

atodorov requested review from carlio and removed request for carlio January 18, 2018 09:35

atodorov force-pushed the merge_fork branch from 2e058dc to f958844 Compare January 18, 2018 09:48

atodorov force-pushed the merge_fork branch from f958844 to ae6351d Compare January 18, 2018 09:52

atodorov and others added 24 commits January 18, 2018 11:53

Update test matrix and how tests are started on Travis

fa083d0

Update the way we load tests

533b66c

this mimics more closely what pylint does for their own tests and doesn't rely on deprecated functionality. Fixes pylint-dev#107 and pylint-dev#97 Obsoletes pylint-dev#98

Remove missing W5101 and W5103 pylint warnings

fbdddd6

Replace C0111 with missing-docstring for better readability

d8a55c3

Add required on_delete attribute, fixes no-value-for-parameter

59257f9

since we're testing with latest Django versions this is now required for all ForeignKey fields

Remove missing IPAddressField b/c we test with Django 1.11+

10d612a

Disable augmentations for missing R0924 badly-implemeted-container

fd68bc1

Remove R0903 too-few-public-methods from test files

85bf1b7

the plugin should be able to suppress these kinds of errors for model classes and also for Meta classes so no need to disable them explicitly.

Use human readable name for suppressed message

4b39e90

also remove couple of suppressions b/c these class checks are already handled by the check for meta class and they don't seem to have any effect

Remove unused tox configuration

8376e28

Add failure notifications for Travis CI

cd1f67d

Drop support for testing on Python 2

5bb7be2

Update comments in test

bec095f

Enable test case which is Django 1.8+

893d72b

this was previously skipped but since we don't test on older versions we can explicitly add it again.

Update format of expected error messages for unicode test

a8f668b

the latest version of pylint expects the error messages in slightly different format.

Enable test for django-rest-framework serializer

18c8f73

Use PYTHONPATH for the shell script referenced in README

527221c

Add common names to good_names instead of modifying const_rgx

81e8294

for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111

Add handler500 to good_names

5f14ada

Support factory_boy's DjangoModelFactory Meta class

0797e73

Added suppressions for [DjangoModelFactory](http://factoryboy.readthedocs.io/en/2.9.2/orms.html#the-djangomodelfactory-subclass). Original PR: pylint-dev#103

Create func_noerror_ugettext_lazy_format.py

ce00090

Checks that Pylint does not complain about django lazy proxy when using ugettext_lazy

ugettext_lazy is supposed to return six.text_type

e9975b5

Fix E1101:Instance of '__proxy__' has no 'format' member' when using .format() on a ugettext_lazy translation NOTE: merged with modifications. Instead of returning str, returns '' Fixes pylint-dev#80 Origina PR: pylint-dev#100

Adding tests and transforms for DurationField

d1e3663

Original PR: pylint-dev#99 Fixes pylint-dev#95

Add json field to WSGIRequest proxy

4241d9d

Original PR: pylint-dev#92

Villiers Strauss and others added 2 commits January 18, 2018 11:54

add support for django.contrib.postgres.fields and also UUIDField

e5767ed

NOTE: merged with modifications: - resolved conflicts - updated where test files are on disk Original PR: pylint-dev#84

Update changelog

f6a5ac2

atodorov force-pushed the merge_fork branch from ae6351d to f6a5ac2 Compare January 18, 2018 09:54

atodorov changed the title ~~[WIP] Merge updated fork~~ Merge updated fork Jan 18, 2018

atodorov mentioned this pull request Jan 18, 2018

Repo is dead - I've made a fork #112

Closed

atodorov merged commit 2193e8b into pylint-dev:master Jan 18, 2018

atodorov deleted the merge_fork branch January 18, 2018 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge updated fork #113

Merge updated fork #113

atodorov commented Jan 18, 2018

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

carlio commented Jan 18, 2018

atodorov commented Jan 18, 2018

carlio commented Jan 18, 2018 •

edited

Loading

colinhowe commented Jan 18, 2018

carlio commented Jan 18, 2018

Merge updated fork #113

Merge updated fork #113

Conversation

atodorov commented Jan 18, 2018

coveralls commented Jan 18, 2018 • edited Loading

coveralls commented Jan 18, 2018 • edited Loading

coveralls commented Jan 18, 2018 • edited Loading

coveralls commented Jan 18, 2018 • edited Loading

carlio commented Jan 18, 2018

atodorov commented Jan 18, 2018

carlio commented Jan 18, 2018 • edited Loading

colinhowe commented Jan 18, 2018

carlio commented Jan 18, 2018

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

coveralls commented Jan 18, 2018 •

edited

Loading

carlio commented Jan 18, 2018 •

edited

Loading