Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let AstroidManager.clear_cache reload brain plugins #1528

Merged
merged 7 commits into from
May 4, 2022
Merged

Let AstroidManager.clear_cache reload brain plugins #1528

merged 7 commits into from
May 4, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Apr 23, 2022 •
edited
Loading

Description

Fixes the incompatible tests in #1521, but unfortunately exposes a new problem. Fixed.

Type of Changes

Type
✓ 🐛 Bug fix

@jacobtylerwalls jacobtylerwalls added this to the 2.12.0 milestone Apr 23, 2022
@jacobtylerwalls jacobtylerwalls force-pushed the fix-cache-stdlib-brain branch from 34f59d4 to 8a9f764 Compare April 23, 2022 17:25
@jacobtylerwalls jacobtylerwalls mentioned this pull request Apr 23, 2022
Merged
@jacobtylerwalls jacobtylerwalls changed the title Allow AstroidManager.clear_cache() to reload necessary brain plugins Let AstroidManager.clear_cache reload brain plugins Apr 23, 2022
@jacobtylerwalls jacobtylerwalls force-pushed the fix-cache-stdlib-brain branch from 6b6c80b to f38e02d Compare April 23, 2022 18:44
@coveralls
Copy link

coveralls commented Apr 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2269716144

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 126 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.09%) to 91.673%
Files with Coverage Reduction New Missed Lines %
astroid/brain/brain_dataclasses.py 2 91.32%
astroid/protocols.py 14 89.1%
astroid/raw_building.py 23 91.45%
astroid/nodes/scoped_nodes/scoped_nodes.py 87 92.41%
Totals Coverage Status
Change from base Build 2212825030: 0.09%
Covered Lines: 9148
Relevant Lines: 9979
💛 - Coveralls

DanielNoord
DanielNoord reviewed Apr 28, 2022
View reviewed changes
astroid/manager.py Outdated Show resolved Hide resolved
DanielNoord
DanielNoord requested changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nitpicks 👍

astroid/manager.py Outdated Show resolved Hide resolved
astroid/manager.py Outdated Show resolved Hide resolved
astroid/manager.py Outdated Show resolved Hide resolved
tests/resources.py Outdated Show resolved Hide resolved
tests/unittest_manager.py Show resolved Hide resolved
@jacobtylerwalls jacobtylerwalls merged commit f125fa7 into pylint-dev:main May 4, 2022
@jacobtylerwalls jacobtylerwalls deleted the fix-cache-stdlib-brain branch May 4, 2022 18:21
This was referenced May 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Bug 🪳
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @coveralls @DanielNoord