Let AstroidManager.clear_cache act on other caches
#1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
clear-cache-alternative
branch
from
2f28b98 to
35171c4
Compare
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 2281918404
💛 - Coveralls |
jacobtylerwalls
changed the title
Manager.clear_cache to other cachesManager.clear_cache act on other caches
jacobtylerwalls
commented
Apr 20, 2022
jacobtylerwalls
added
the
Maintenance
DanielNoord
reviewed
Apr 21, 2022
Co-authored-by: Pierre Sassoulas <[email protected]>
jacobtylerwalls
changed the title
Manager.clear_cache act on other cachesAstroidManager.clear_cache act on other caches
jacobtylerwalls
removed
the
Blocked 🚧
DanielNoord
reviewed
May 4, 2022
DanielNoord
approved these changes
May 5, 2022
| result = _NORM_PATH_CACHE[path] = _normalize_path(path) | ||
| return result | ||
| if not path: # don't cache result for '' | ||
| return _normalize_path(path) |
There was a problem hiding this comment.
This line is not covered, on the other hand are we really ever having something falsey here ?
There was a problem hiding this comment.
I added coverage. We talked a bit about it here.
| @@ -23,8 +23,6 @@ | |||
| Union, | |||
| ) | |||
|
|
|||
| import wrapt | |||
There was a problem hiding this comment.
I was wondering if we could remove the dependency to wrapt following this change, Turns out that there are other uses elsewhere but not that much.
|
Ah, another test isolation issue to look into. |
jacobtylerwalls
commented
May 6, 2022
| @@ -179,7 +179,7 @@ def test_load_packages_without_init(self) -> None: | |||
| https://github.com/PyCQA/astroid/issues/1327 | |||
| """ | |||
| tmp_dir = Path(tempfile.gettempdir()) | |||
| self.addCleanup(os.chdir, os.curdir) | |||
| self.addCleanup(os.chdir, os.getcwd()) | |||
There was a problem hiding this comment.
We need to actually find the cwd before changing dir, otherwise this cleanup won't do anything.
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #1242. See #1242 (review)
Type of Changes
Related Issue
Resolves #792 (but let's get a benchmark and find out)