Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tinybase: Rework storage interface #738

Merged
merged 14 commits into from
Sep 25, 2023
Merged

Tinybase: Rework storage interface #738

merged 14 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Format black

    @pyiron-runner @pmrv
    pyiron-runner authored and pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4b323ff View commit details
    Browse the repository at this point in the history

  2. Tinybase: Rework storage interface 

    Previously Storable implementions of `AbstractTask` and `TinyJob` simply
pickled everything at the highest level because some ASE objects
couldn't be written directly with the Storable interface.  This change
adds some functionality to GenericStorage that will automatically detect
such objects and pickle only those transparently to the rest of
tinybase. As such the full object hierarchy is now represented in
storage and neither tasks nor jobs need to know whether some internal
objects of theirs have been pickled.

It also adds some amount of docstrings and specs to the storage related
classes.
    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c02190a View commit details
    Browse the repository at this point in the history

  3. Update class reference

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c663bd6 View commit details
    Browse the repository at this point in the history

  4. Remove breakpoint

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f5015d7 View commit details
    Browse the repository at this point in the history

  5. Add ListStorable and patch over some glitches

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3a920a7 View commit details
    Browse the repository at this point in the history

  6. Catch ValueError as well 

    FileHDFio raises also that
    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ba7fdea View commit details
    Browse the repository at this point in the history

  7. Update Basic Notebook

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e1cb758 View commit details
    Browse the repository at this point in the history

  8. Update ASE notebook

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ca68e9c View commit details
    Browse the repository at this point in the history

  9. Update Shell notebook

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    188ed6b View commit details
    Browse the repository at this point in the history

  10. Update Lammps notebook

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b6dfd35 View commit details
    Browse the repository at this point in the history

  11. Fix small typo in cpu default

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    fe7e204 View commit details
    Browse the repository at this point in the history

  12. Update TinyJob notebook

    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    aa819c2 View commit details
    Browse the repository at this point in the history

  13. Do not use nglview in notebooks 

    It is not available in the testing env
    @pmrv
    pmrv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d7bae76 View commit details
    Browse the repository at this point in the history

  14. Format black

    @pyiron-runner
    pyiron-runner committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d03aa9d View commit details
    Browse the repository at this point in the history