Tinybase: Rework storage interface #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrv
added
enhancement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
pmrv
commented
Jun 23, 2023
pmrv
added
format_black
Previously Storable implementions of `AbstractTask` and `TinyJob` simply pickled everything at the highest level because some ASE objects couldn't be written directly with the Storable interface. This change adds some functionality to GenericStorage that will automatically detect such objects and pickle only those transparently to the rest of tinybase. As such the full object hierarchy is now represented in storage and neither tasks nor jobs need to know whether some internal objects of theirs have been pickled. It also adds some amount of docstrings and specs to the storage related classes.
FileHDFio raises also that
Pull Request Test Coverage Report for Build 6297948464
💛 - Coveralls |
It is not available in the testing env
pmrv
added
format_black
|
@liamhuber This fixes now most of the CI problems with tinybase. The last error is related to some environment hacks. I had added a pyiron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Storable implementions of
AbstractTaskandTinyJobsimplypickled everything at the highest level because some ASE objects
couldn't be written directly with the Storable interface. This change
adds some functionality to GenericStorage that will automatically detect
such objects and pickle only those transparently to the rest of
tinybase. As such the full object hierarchy is now represented in
storage and neither tasks nor jobs need to know whether some internal
objects of theirs have been pickled.
It also adds some amount of docstrings and specs to the storage related
classes.
Pending #734