Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_pandas #594

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Remove get_pandas #594

merged 1 commit into from
Dec 14, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Dec 14, 2021

Fixes #592.

Just to see if any compatibility tests break.

@pmrv pmrv added enhancement New feature or request integration Start the integration tests with pyiron_atomistics/contrib for this PR labels Dec 14, 2021
jan-janssen
jan-janssen approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pmrv pmrv merged commit a6b37a3 into master Dec 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the get_pandas branch December 14, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request integration Start the integration tests with pyiron_atomistics/contrib for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is JobCore.get_pandas really needed?
2 participants
@pmrv @jan-janssen