Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is JobCore.get_pandas really needed? #592

Closed
pmrv opened this issue Dec 14, 2021 · 1 comment · Fixed by #594
Closed

Is JobCore.get_pandas really needed? #592

pmrv opened this issue Dec 14, 2021 · 1 comment · Fixed by #594
Labels
enhancement New feature or request

Comments

@pmrv
Copy link
Contributor

pmrv commented Dec 14, 2021

This function

def get_pandas(self, name):

just delegates to job.project_hdf5.get_pandas and does nothing else. I've also never seen it used anywhere.

Since it's on JobCore almost every object in pyiron has that method, so it takes up a good amount of tab-complete real estate and is sometimes even actively confusing, e.g. on pyiron tables. There you need to call get_dataframe instead, but get_pandas also pops up, so users need to double check with the docstring to get the correct one.

@pmrv pmrv added the enhancement New feature or request label Dec 14, 2021
@jan-janssen
Copy link
Member

I guess it is one of the loose ends from an rather old pyiron version so I am fine with removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants