Force window surface update after set_size, hopefully proper fix for that pesky frequent pypy test fail #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damusss
approved these changes
May 21, 2024
MyreMylar
approved these changes
May 22, 2024
oddbookworm
approved these changes
May 23, 2024
|
is this really how we want to to things? I added this behaviour to pygame.display as a hack to keep backward compat with pygame 1.9, which required a call to set_mode after a VIDEORESIZE event. |
|
There is absolutely no behaviour change happening here. All it does is add an extra call to Did you mean to comment this on another issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the hacky test fix applied in #2832 that didn't work out
This new approach essentially forces the update via
SDL_GetWindowSurfaceto happen immediately, so we are now ensuring that the window surface is updated before we even leave the function call.