Try sleeping in window autoresize test #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully reduce number of CI failures
damusss
approved these changes
Apr 28, 2024
Hopefully reduce number of CI failures
Starbuck5
approved these changes
Apr 29, 2024
itzpr3d4t0r
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to hopefully reduce number of CI failures on this test.
Example failures:
https://github.com/pygame-community/pygame-ce/actions/runs/8573054619/job/23496953618?pr=2793
https://github.com/pygame-community/pygame-ce/actions/runs/8506569444/job/23297052392?pr=2766
I'm assuming that it is failing because the surface event has not yet been processed by the system at the time of checking and thus the callback has yet to be called for our window surface.
Adding a small delay after resizing the window should allow the system a chance to catch up.
If this doesn't work - we could also just try disabling it on Pypy where it seem to happen most often.