Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of recently modified fits #983

Closed
blitzmann opened this issue Feb 11, 2017 · 2 comments
Closed

List of recently modified fits #983

blitzmann opened this issue Feb 11, 2017 · 2 comments
Labels
done This task is done! \o/ enhancement This is a feature request, or an idea to enhancement a current feature

Comments

@blitzmann
Copy link
Collaborator

see #982 (comment)

I don't know if it's best to have a panel or button to toggle the view. The default ship Category listing is quite large to begin with and I think being able to hide this might be a good idea.

Additionally, we don't ahve any way of pulling back recently changed fits. We don't have a modified timestamp on fits, nor a last opened timestamp. We only have a created timestamp, which I don't believe works well with this.

@blitzmann blitzmann added the enhancement This is a feature request, or an idea to enhancement a current feature label Feb 11, 2017
@Ebag333
Copy link
Contributor

Ebag333 commented Feb 11, 2017

I believe that a certain smart person recently suggested adding a modified column to tables. 😁

slechirine pushed a commit to slechirine/Pyfa that referenced this issue May 9, 2017
Conflicts:
	eos/db/saveddata/character.py
	eos/db/saveddata/fit.py

Implements pyfa-org#983 but utilizing sqlalchemy events to update the fit modified date whenever something is added/changed.
@blitzmann
Copy link
Collaborator Author

This has been released. :D Any fitting change (adding/removing modules, drones, projected and command fits, or modifying modules by adding charges, changing state, etc) should update the fit's modified date in the database

A note for mac-deprecated users:

Recent fits will only show the most recently created fits, or most recent fits that had their name / character / notes / (whatever data is stored as the fit record in the database) changed. This is due to a limitation in sqlalchemy v0.6, which the mac-deprecated build uses, specifically with respect to the lack of events. For those still on the deprecated version, try out the non-deprecated version - if there's any issues, please let me know through an existing issue or open a new one :)

@blitzmann blitzmann added the done This task is done! \o/ label May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This task is done! \o/ enhancement This is a feature request, or an idea to enhancement a current feature
Projects
None yet
Development

No branches or pull requests

2 participants