-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Fittings search input box shown by default #982
Comments
I'm not sure why we hide it. It'd make a lot more sense to leave it up, and have a X to the right to clear it. I think the idea was to keep the interface from being cluttered, which has value, but having your UI as static as possible also has value.
This in particular I disagree with. We should never take control away from users. Especially for users such as myself who rarely uses the search box, and flips between tabs often. Other than that, I think it's a good idea, if someone else doesn't get around to implementing it I will eventually, but right now am focused on finishing a big refactoring push. |
CTRL+F brings up the search box and focuses it for you so that you can immediately start typing. This should be pretty intuitive since most every program has a CTRL+F find feature. Also: CTRL-F works on Market Browser as well. CTRL-SPACE switches between the two tabs. Knowing these shortcuts, do you think that would be sufficient for your use cases? I could also put a note on search button tooltip to tell users the shortcut is possible. Honestly, I don't want to muck with this |
we don't capture all keyboard input and immediately start a search, no. But, as stated, CTRL+F does automatically put focus onto the search box, :) I think we're going to keep it the way it is (and I'll add a small bit of text to the tooltip)
Now this is a feature request that I like, and I don't know why no one has ever brought it up before. It would be more difficult though as you said, and we would have to modify the database a bit (we don't currently store a timestamp when modifying fit). I'm going to close this issue and open up another one for this specifically. Thanks! |
Small feature (and silly, I know) request. I haven´t been using this app for too long, but is there any reason why you have to click the rather small magnifying glass in the fitting tab to show the search input?
Looks like it could work like in the market tab, and be shown by default to avoid the click every time you want to look for a fit (at least for us that use PYFA mostly to manage fittings)
It could also automatically put the cursor on the search box (on tab change between Market and Fittings).
"Should" not affect normal operation, since all hotkeys work even with the inputbox focused.
I think it could improve usability a bit.
The text was updated successfully, but these errors were encountered: