Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on opening fit / searching market #598

Closed
blitzmann opened this issue May 3, 2016 · 73 comments
Closed

Crash on opening fit / searching market #598

blitzmann opened this issue May 3, 2016 · 73 comments
Labels
bug Confirmed to be a bug investigate Issue needs more investigation and discussion before a solve is implemented workaround-available Affected by this issue? Check the thread for a workaround!

Comments

@blitzmann
Copy link
Collaborator

blitzmann commented May 3, 2016

Some folks are experiencing random crashes in Windows. If you're experiencing these issues, please post here and subscribe to the thread - I may have you try to test a few things.

EDIT:

  • Crashes happen with the Citadel Pre Release. v1.20.1 is unaffected.

WORKAROUND:

  • Running pyfa in administrator mode fixes the crashes according to some users. 0.o
@blitzmann blitzmann added the investigate Issue needs more investigation and discussion before a solve is implemented label May 3, 2016
@blitzmann blitzmann added the bug Confirmed to be a bug label May 3, 2016
@IndianaJars
Copy link

Crashes within 10 Seconds of opening a fit, tried different fits, tried uninstalling and reinstalling

@Zagor24
Copy link

Zagor24 commented May 4, 2016

I've been experiencing crashes as well. Every time i open an already fitted ship, or if i try to fit modules on a blank fit, the client crashes.
If i open a new fit with no modules, the client remains stable, i can check ship stats, change character profiles etc... but as soon as i open some module category in the market section and look at individual modules, it crashes.
I know for a fact that it started out of the blue, before i installed the citadel update. Previous version was working fine, then i havent used it for some time, and wanted to check something around the time citadel went live, and it started crashing. I thought updating to the latest version would fix it (i even deleted the client completely, and made a fresh install), but it didnt help.
Tried multiple ships and fits, same thing. I'm running Win 10 64bit.

@blitzmann
Copy link
Collaborator Author

Did you guys try the Citadel pre-release? If so, were you experiencing crashes on that build? If you haven't, please download and test it out (on the Releases page) - it should use a separate test database so you current fits shouldn't be affected.

@locten
Copy link

locten commented May 4, 2016

can confirm importing a fit crashes both Preview: Character Implants build and singularity-1027729: Citadel Pre-Release build after around 5-10 seconds.

@aran-hotchkiss
Copy link

Someone commented on the EvE-o forums about running the program in administrator mode....
I tried that and it seems to have resolved all issues for me - hasn't crashed once since I did that. Suggest you fellas try it and see if it works.

@locten
Copy link

locten commented May 4, 2016

ok so apparently running as admin fixed the problem could have sworn i had already tried that its usually the 1st thing i try if something crashes but guess i dident.

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 4, 2016

What the literal fuck... That makes no sense. BUT, gives me more information so yay. Updating the OP

@Zagor24
Copy link

Zagor24 commented May 4, 2016

Confirmed, its working in admin mode.

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 4, 2016

Can you guys try the Character Implant Preview and let me know if that build crashes?

https://github.com/pyfa-org/Pyfa/releases/tag/preview_char_implants To prevent database corruption, I wouldn't modify your chars while running that build, as it currently uses your current user database and I'm not sure how it will react with this older version.

@blitzmann
Copy link
Collaborator Author

Also, take a peek in event viewer and post the info it has on pyfa:

Quick and dirty: http://www.cyberlink.com/support/faq-content.do?id=10449

@Zagor24
Copy link

Zagor24 commented May 4, 2016

Here's the info from the Event Viewer:

Faulting application name: pyfa.exe, version: 1.15.1.0, time stamp: 0x549debdc
Faulting module name: COMCTL32.dll, version: 6.10.10586.0, time stamp: 0x5632d2bf
Exception code: 0xc000041d
Fault offset: 0x0007dc89
Faulting process id: 0x2848
Faulting application start time: 0x01d1a5c88c324ce4
Faulting application path: C:\Program Files (x86)\pyfa\pyfa.exe
Faulting module path: C:\WINDOWS\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.10586.0_none_d3c2e4e965da4528\COMCTL32.dll
Report Id: 4fb54582-797e-464e-8c69-24641e8f45fb
Faulting package full name:
Faulting package-relative application ID:

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 4, 2016

@zagor thanks. Can you also try the character implant preview release and let me know if that crashes as well? I'm just trying to narrow down which changes may have caused the offending crash

EDIT: pretty sure this relates to something in the GUI. The module that fails is Windows Common Controls, which I believe is where wxwidgets gets it's UI elements from.

@locten
Copy link

locten commented May 5, 2016

so i tried the character implant preview and it dident crash opened event viewer to try and get that for you turned auto use admin mode off and now it docent crash even if i don't run as admin...

@locten
Copy link

locten commented May 5, 2016

even deleting all associated files and reinstalling and running without admin it docent crash any more so im super confused now lol

@ullerrm
Copy link

ullerrm commented May 5, 2016

One reproducable crash: Open a fit in a tab, then delete the fit from the Ships pane.

@blitzmann
Copy link
Collaborator Author

For those experiencing the crash, please send me your database file (%userprofile%/.pyfa/saveddata.db). Email is in README.

Can I get others to confirm that it doesn't crash when running the character preview build? Getting more confirmation will help narrow it down.

@ullerrm that is a different issue that's been known about. See #164

@blitzmann
Copy link
Collaborator Author

Can anyone else confirm the above?

@digitalwolf
Copy link

I have the crash, even in the preview build, unless I run as administrator.

@ErinOswell
Copy link

ErinOswell commented May 7, 2016

Confirming this; crashes when I have a fitting open and search for a module in market tab, oddly it works fine searching in the market tab with no fittings open. Will try running as admin.

EDIT: Confirmed running as admin solved the crash issue for now.

@Ecnav
Copy link

Ecnav commented May 7, 2016

I am having the exact same issue as ErinOswell and running as administrator seems to have worked for me as well.

@mrnsnp
Copy link

mrnsnp commented May 7, 2016

Crash occurs shortly after I switch over to market tab to start ship fitting. Win10 Pro

•System
◦Provider
[ Name] Windows Error Reporting
◦EventID 1001
[ Qualifiers] 0
Level 4
Task 0
Keywords 0x80000000000000
◦TimeCreated
[ SystemTime] 2016-05-07T15:42:19.247618900Z
EventRecordID 1255
Channel Application
Computer DELLONE-PC
Security
•EventData
108127056753
1
APPCRASH
Not available
0
pyfa.exe
1.15.1.0
549debdc
COMCTL32.dll
6.10.10586.0
5632d2bf
c0000005
0007dc89
C:\Users\DELL ONE\AppData\Local\Temp\WER4EA7.tmp.WERInternalMetadata.xml
C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_pyfa.exe_cb32231e4999c411fdf6dbbd71d651675f20ab_971b30ad_dd577048
0
169a3bf8-4255-46ae-84e9-6e9d5da189e4
0
3a41bcf74eaf715fbe0cecd144234446

@blitzmann
Copy link
Collaborator Author

@digitalwolf when you say preview release, do you mean the citadel preview or the character implant preview?
I want to make sure that the crash is / is not happening with this one: https://github.com/pyfa-org/Pyfa/releases/tag/preview_char_implants

@blitzmann blitzmann changed the title Random Crashes Crash on opening fit / searching market May 7, 2016
@aaronmallen
Copy link

+1

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 8, 2016

Alright guys, I have a favor to ask of you. Can you please download and run each of these builds and note if the crashing happens? Try each build two or three times. Make sure they stay separate (do not overwrite one build install with another, keep them separate after extracting).

When done, please post results here (which builds worked, which builds failed. Each build archive is prefixed with a number that you can use to identify each one). This is extremely important in trying to narrow down which change causes the crashing, because after looking through the relevant code there is no reason to require admin privileges.

It should also be noted that these builds should be using their own test database, so it shouldn't affect your user user database with fits.

http://dl.eve-files.com/media/1605/1-pyfa-20160508-dc55db-win.zip
http://dl.eve-files.com/media/1605/2-pyfa-20160508-ca34d7-win.zip
http://dl.eve-files.com/media/1605/3-pyfa-20160508-48b45b-win.zip
http://dl.eve-files.com/media/1605/4-pyfa-20160508-443c91-win.zip
http://dl.eve-files.com/media/1605/5-pyfa-20160508-80e47d-win.zip
http://dl.eve-files.com/media/1605/6-pyfa-20160508-ca91f6-win.zip
http://dl.eve-files.com/media/1605/7-pyfa-20160508-0d41cb-win[1].zip

@Aarondorn2
Copy link

Also happening for me about 10-20 seconds after launching the app. Tried uninstalling, reinstalling, previous versions, different fits, etc.

@blitzmann
Copy link
Collaborator Author

What do you mean by different versions? Others have stated that 1.20 seems to work. Is that not the case for you? Can you also look at my previous comments and test out those builds that I provided

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 12, 2016

@mrnsnp excellent info, thank you! Is there a way to export the results of sysinternals, or take a screenshot with as much relevant info as you can?

Can you also try these versions and tell me if sysinternals gives the same information for the crash:
https://github.com/pyfa-org/Pyfa/releases/tag/v1.17.1
https://github.com/pyfa-org/Pyfa/releases/tag/v1.18.0
https://github.com/pyfa-org/Pyfa/releases/tag/v1.19.1

@mrnsnp
Copy link

mrnsnp commented May 12, 2016

There is however I didn't have my usb drive at work, so anything submitted for the next 36 hrs is going to be based off of my home system. I'll update this post based on relevant info for the listed releases.
This is interesting, I launched PYFA with my sysinternals suite active on my home device and its not crashing using PYFA build 1.21.1

Sent you some log files. All generated using pyfa 1.21.1, since this is where the errors started occurring. Wondering if me running Sysinternals and Visual Studios loaded since this morning made a system change that's stopped the crash.

Downloaded PYFA 1.17.1, 1.18.0, and 1.19.1. No issues to report on my machine in terms of crashes.

PYFA 1.17.1 - Generated a large number of buffer overflow calls. All Related to RegQueryValue, QuerySecurityFile, QueryAllInformationFile, RegEnumValue.
PYFA 1.18.0 - Generated a large number of Buffer Overflow calls. All related to RegEnumValue, RegQueryValue,
PYFA 1.19.1 - Generated a large number of buffer overflow calls. All related to QueryAllinformationFile and RegQueryValue, RegEnumValue,

90% of the QueryAllInformationFile tend to be from imgs.zip and pyfa\settings. Not sure if python has anything designed to handle responses that overflow the starting buffer.

I know that buffer overflow on the stack can cause programs to do weird things do to loss information its expecting.

If someone else would be willing on a Windows sytem, install Visual Studio Community 2015 with Update 2 - Free. VS Community 2015 has support for python, so perhaps, there is a DLL or something from it that has stopped the crash. I wont be able to verify with my work machine until 5/13.

@blitzmann
Copy link
Collaborator Author

Yeah, whenever you can please provide comprehensive evaluation of the versions listed (as well as current release of course) along with exported data / screenshots. That's the next best thing to being able to reproduce it myself.

@blitzmann
Copy link
Collaborator Author

@mrnsnp I see you update your post. I'll take a look at it when I can and go from there. In the future though please make a new post to the thread - I don't receive notifications for post edits like I do for new posts, and it'll be easy to miss. =)

@blitzmann
Copy link
Collaborator Author

Update: I also get buffer overflows. However, I don't believe these are errors (see http://superuser.com/questions/491597/process-monitor-entrys-with-buffer-overflow), and I don't think they are related to the problem here (which I would think would happen with or without admin rights).

@mrnsnp you stated that 1.17, 1.18, and 1.19 work fine without admin rights, correct? That contradicts what @Aarondorn2 said in his comment (#598 (comment)) so I'm not sure if there's another separate issue there.

I'll be posting to the wxpython group today to see if anyone has any ideas.

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 15, 2016

more info: the exception that causes the crash is one of these two:

  • 0xc000041d - STATUS_FATAL_USER_CALLBACK_EXCEPTION
  • 0xc0000005 - ACCESS VIOLATION

Access violation seems to be most common (only one report of the first one)

@hom3gr0wn
Copy link

Wiped out windows and works fine now I think it's Microsoft maybe a dll file issue

@SpeedProg
Copy link
Contributor

I can only tell you one thing if I run it from source there are no problems at all.
your packed files from the downloads crash, so I am pretty sure there is an issue with the packaging xD

@blitzmann
Copy link
Collaborator Author

In that case, I'll try to rebuild the binaries (ugh) and post here for testing.

@mavu
Copy link

mavu commented May 18, 2016

Hi, I know the bug says windows, but I experience the same or something very similar on linux running the current master branch. (since about the citadel release, can't say anything about earlier, only resubbed recently)

There are possibly 2 issues because most of the time it just crashes with "Segmentation fault", but rarely I get some debug info. (don't have it at hand, will update when it happens again.)

Is there any kind of debug mode where I can get more messages out of it, to help debug?
Should I make a Linux-only bugreport seperate from this one?

edit:

No idea what i'm doing, but here is a GDB output possibly pointing to sqlite3?

http://pastebin.com/Lc5UepfJ
http://pastebin.com/YjRAsYfB

@blitzmann
Copy link
Collaborator Author

@mavu Which distro and version are you using? What version of sqlalchemy? Does this happen with searching the market, fitting the ship, browser fits, etc? Can you please try earlier versions (the latest point releases for 1.19, 1.20) and let me know if they experience the same issue.

@blitzmann
Copy link
Collaborator Author

@mavu Also, in eos/config.py there is a debug flag. Please set this tie debug = True and try again. IIRC, this should enable debugging in sqlalchemy, which should print out the sql statements that it's using. Post that here, it might help.

@mavu
Copy link

mavu commented May 18, 2016

Using fresh debian testing (updated today, last update some month back)
Package: python-sqlalchemy Version: 1.0.12+ds1-1

It happens when fitting modules and selecting fits (feels more rare, but you do that less often, so...).
here is a pastebin with Debug=True: http://pastebin.com/gmv9jdmx

I am guessing update prices happens in both those cases? A clue?
I'll try the point releases next. is there a way to disable the prices/market stuff?

edit: http://pastebin.com/QYsyJGyP

I disabled market updates in the settings, and this time the crash happened while moving a module from a slot to another slot.

@blitzmann
Copy link
Collaborator Author

blitzmann commented May 18, 2016

Check to see if you have automatic HTML exports enabled in the preferences, and disable it if you do so.

@mavu
Copy link

mavu commented May 18, 2016

Yes, it was enabled, switched off, and it feels carefully optimistic, as it has not crashed since, and I shuffled stuff around, but not long enough to say its stable.

@blitzmann
Copy link
Collaborator Author

Please let me know of your outcome. I really should remove the auto HTML export - it's always given us problems.

@mavu
Copy link

mavu commented May 20, 2016

Ok, re-enabled the market updates, left HTML export off. no crash since.
I'd make the automatic HTML export off-by-default, people always complain if you remove features :)

Hmm. actually it probably is off by default, isn't it? I must have used that sometime.

@MaxHeadRom
Copy link

For about 2 years now Pyfa consistently crashes on me whilst I'm just doing the usual clicking through ships or market items. I've updated with every new release over the years but the same issue remains. I've uninstalled and reinstalled numerous versions. Running as administrator has no effect. The issue occurred in Win 7 and now also in Win 10. I've googled this problem but couldn't find anyone else with exactly the same issue so I've just put it down to a corrupt file somewhere which doesn't get updated/uninstalled/fixed. I'm kind of getting fed up with it now as I usually have to restart Pyfa a few times in the space of half a hour. If you could help me sort this out I'm be mighty grateful! Cheers.

@MaxHeadRom
Copy link

My crash report:

Faulting application name: pyfa.exe, version: 1.15.1.0, time stamp: 0x549debdc
Faulting module name: ntdll.dll, version: 10.0.10586.306, time stamp: 0x571afb7f
Exception code: 0xc0000005
Fault offset: 0x00026d79
Faulting process id: 0x307c
Faulting application start time: 0x01d1d810a676768e
Faulting application path: C:\Program Files (x86)\pyfa\pyfa.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: eb74bcb3-6d18-43b1-8fc4-1e25797f0a81
Faulting package full name:
Faulting package-relative application ID:

@blitzmann
Copy link
Collaborator Author

@MaxHeadRom I have never headr of that issue before. The module at fault is ntdll.dll which is a core Windows file. I wonder if that file is corrupt. You said it happened on Win7 and Win10, did you by chance upgrade from 7 to 10 or was it a clean install?

@MaxHeadRom
Copy link

Yeah right.... Windows was upgraded 7 to 10.

@blitzmann
Copy link
Collaborator Author

I know it's not ideal, but maybe try a clean install with windows 10.

I have no idea why pyfa is crashing with the module being at fault. Everything I read online points to ntdll.dll being corrupted, or something like nvidia driver issues. This is something that I've never seen happen with pyfa, hence why I believe it's localized to your machine. =(

@MaxHeadRom
Copy link

Thanks for your assistance. I've just ran System file checker and it reported/ fixed corrupt files. The log file is quite lengthy! I'll restart and test Pyfa again.

@MaxHeadRom
Copy link

Hey Ryan SFC seems to have zapped that gremlin, I can now merrily click away without crashing. Happy days! Cheers mate.

@blitzmann
Copy link
Collaborator Author

blitzmann commented Jul 8, 2016

wtf I can't believe that worked. Wonderful!

Mind posting the program you used in case others come across the issue? Who knows, it might help folks with the admin privs issue. Or was it the built in system check?

@MaxHeadRom
Copy link

MaxHeadRom commented Jul 8, 2016

I just followed the instructions on this link I found via google pertaining to fixing registry files, it advises the use of the Windows system app SFC which I've never heard of. It worked wonders!

http://www.howtogeek.com/222532/how-to-repair-corrupted-windows-system-files-with-the-sfc-and-dism-commands/

Cheers man!

@blitzmann
Copy link
Collaborator Author

Ah, SFC was advised somewhere in this thread as well. Doesn't help the folks who are having the admin privs though, but I'm glad it worked for you. =)

@bosonn
Copy link

bosonn commented Oct 15, 2016

@blitzmann

I had the same issue as @MaxHeadRom on 3 machines, 7/8.1/10.

A1: Application Name: pyfa.exe
Fault Module Name: sqlite3.dll
Exception Code: c0000005
Exception Offset: 000142d6
Additional Information 1: 5861
Additional Information 2: 5861822e1919d7c014bbb064c64908b2
Additional Information 3: 1318
Additional Information 4: 13181ae637ac2592fac0ca2dd662cdcc

SFC worked on windows 10 for me, but did not work on any other os.

This thread resolved this issue for me on 7 and 8.1.

@blitzmann
Copy link
Collaborator Author

We haven't had a report of crashing since last year - whatever it was seems to have cleared up either with Windows updates or with a subsequent release of pyfa. I am still not sure what caused the requirement for admin rights, and would love to know if anyone is still experiencing that issue or if you can now run without Admin.

Since there hasn't been any activity in this thread for some time now, I'm going to close it. Please feel free to continue to comment if things start acting up again, or if you wish to divulge general information.

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug investigate Issue needs more investigation and discussion before a solve is implemented workaround-available Affected by this issue? Check the thread for a workaround!
Projects
None yet
Development

No branches or pull requests