Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pronunciation guide to the word Xarray in the README.MD fil… #7677

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

Chinemere
Copy link
Contributor

Added a pronunciation guide to the word Xarray in the README.MD file so users can easily pronounce the word correctly

…e so users can easily pronounce the word correctly
Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Chinemere! It never occurred to me that this was ambiguous but it definitely is, thank you.

README.md Outdated Show resolved Hide resolved
@TomNicholas TomNicholas enabled auto-merge (squash) March 27, 2023 21:44
Copy link
Contributor Author

@Chinemere Chinemere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TomNicholas, I appreciate your feedback, I am pretty new to contributing to open source, but I assure you that I am a fast learner.

In your comment, you said "If you hit commit next to my change, it will merge the change into your pull request " kindly bear with me, I can't seem to find any button that says commit next to your change.

I could only see a button that said review changes, then I made this comment, When I tried to click on the approve option, it said Pull request authors are not allowed to make approvals. so I just went ahead and clicked on review changes.
I wouldn't know if this is enough to commit your changes to my pull request. Kindly let me know what you think.

Moreover please is there a way I can reach out to you? I tried reaching out to you on Twitter and the provided email, but I have not been successful with that. The mail seems to be invalid.

I am trying to record my contributions to this project and I would greatly need your help to guide me on the timelines for this project and know the next action to be taken.

Thanks once again for all you do for the Open Source community, I am eagerly waiting for your response.

@TomNicholas
Copy link
Member

In your comment, you said "If you hit commit next to my change, it will merge the change into your pull request " kindly bear with me, I can't seem to find any button that says commit next to your change.

You can ignore this comment - I suggested a change, asked you to commit it, then realised it would be simpler for you if I just used my admin rights to commit it myself, and edited my comment to remove the recommendation. Sorry for the confusion.

Moreover please is there a way I can reach out to you? I tried reaching out to you on Twitter and the provided email, but I have not been successful with that. The mail seems to be invalid.

Sorry! I've been getting a lot of messages from Outreachy applicants and have not managed to reply to them all 😢 The email should not be invalid though - where did you send it?

If you have questions about xarray itself they should be raised on the repository though - you don't need to contact me directly for that. Also if you raise them publicly on the repository it gives other people a chance to answer if I don't see it.

If you have questions about Outreachy specifically then ask them either on the discord channel or by emailing me (thomas dot nicholas at columbia dot edu).

@TomNicholas TomNicholas merged commit c5b88bf into pydata:main Mar 29, 2023
@dcherian
Copy link
Contributor

Thanks for your contribution @Chinemere !

Moreover please is there a way I can reach out to you? I tried reaching out to you on Twitter and the provided email, but I have not been successful with that.

Note that open-source projects run on volunteer time (mostly) and it can be hard to respond very quickly. It may even take a few days, so it's usually best to be patient and ping in a week or so if you haven't received a response.

dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 29, 2023
* upstream/main:
  Save groupby codes after factorizing, pass to flox (pydata#7206)
  [skip-ci] Add compute to groupby benchmarks (pydata#7690)
  Delete built-in cfgrib backend (pydata#7670)
  Added a pronunciation guide to the word Xarray in the README.MD fil… (pydata#7677)
  boundarynorm fix (pydata#7553)
  Fix lazy negative slice rewriting. (pydata#7586)
  [pre-commit.ci] pre-commit autoupdate (pydata#7687)
  Adjust sidebar font colors (pydata#7674)
  Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 (pydata#7682)
  Raise PermissionError when insufficient permissions (pydata#7629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants