Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete built-in cfgrib backend #7670

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Delete built-in cfgrib backend #7670

merged 4 commits into from
Mar 29, 2023

Conversation

dcherian
Copy link
Contributor

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file io topic-backends labels Mar 24, 2023
headtr1ck
headtr1ck approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Should we ping cfgrib to let them know about this change, so they can transfer the removed tests, if they did not do this already?

@headtr1ck headtr1ck added the plan to merge Final call for comments label Mar 24, 2023
@jhamman
Copy link
Member

jhamman commented Mar 28, 2023

Should we ping cfgrib to let them know about this change, so they can transfer the removed tests, if they did not do this already?

☝️ @alexamici and @aurghs

@dcherian
Copy link
Contributor Author

Should we ping cfgrib to let them know about this change, so they can transfer the removed tests, if they did not do this already?

cc @iainrussell

@dcherian dcherian merged commit 0159e45 into pydata:main Mar 29, 2023
@dcherian dcherian deleted the del-cfgrib branch March 29, 2023 15:19
dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 29, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into feature/rolling-pad
d02d2fd 
* upstream/main:
  Save groupby codes after factorizing, pass to flox (pydata#7206)
  [skip-ci] Add compute to groupby benchmarks (pydata#7690)
  Delete built-in cfgrib backend (pydata#7670)
  Added a pronunciation guide to the word Xarray in the README.MD fil… (pydata#7677)
  boundarynorm fix (pydata#7553)
  Fix lazy negative slice rewriting. (pydata#7586)
  [pre-commit.ci] pre-commit autoupdate (pydata#7687)
  Adjust sidebar font colors (pydata#7674)
  Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 (pydata#7682)
  Raise PermissionError when insufficient permissions (pydata#7629)
@iainrussell
Copy link

Hi, I've tested cfgrib, and another package that uses cfgrib, with the main branch of xarray and all looks good!

@malmans2
Copy link
Contributor

malmans2 commented Jun 1, 2023

The cfgrib notebook in the documentation is broken. I guess it's related to this PR.
See: https://docs.xarray.dev/en/stable/examples/ERA5-GRIB-example.html

@headtr1ck
Copy link
Collaborator

The cfgrib notebook in the documentation is broken. I guess it's related to this PR.
See: https://docs.xarray.dev/en/stable/examples/ERA5-GRIB-example.html

Same problem with #7841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file io plan to merge Final call for comments topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate cfgrib backend
5 participants
@dcherian @jhamman @iainrussell @malmans2 @headtr1ck