Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate concat #4346

Merged
merged 5 commits into from
Aug 19, 2020
Merged

annotate concat #4346

merged 5 commits into from
Aug 19, 2020

Conversation

mathause
Copy link
Collaborator

The issue mentions xr.Dataset.to_dataframe and xr.concat. xr.Dataset.to_dataframe was annotated in #4333, so only xr.concat is left.

@pep8speaks
Copy link

pep8speaks commented Aug 16, 2020 •
edited
Loading

Hello @mathause! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-17 00:00:24 UTC

max-sixty
max-sixty approved these changes Aug 17, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathause mathause merged commit 68d0e0d into pydata:master Aug 19, 2020
@mathause mathause deleted the annotate_concat branch August 19, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing return type annotations
3 participants
@mathause @pep8speaks @max-sixty