New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return type annotations #4238

Closed

eric-czech opened this issue Jul 18, 2020 · 1 comment · Fixed by #4346

eric-czech commented Jul 18, 2020

Dataset.to_dataframe should have a return type hint like DataArray.to_dataframe.

Similarly, can concat have a Union[Dataset, DataArray] return type or is it more complicated than that?

The text was updated successfully, but these errors were encountered:

Member

shoyer commented Jul 19, 2020

Yes, this would be very welcome!

In theory concat might be able to use @overload to indicate a more precise type, but Union[Dataset, DataArray] would be a good start.

mathause mentioned this issue

annotate concat #4346

Merged

3 tasks

mathause closed this as completed in #4346

hammer mentioned this issue

Support explicitly setting a dimension order with to_dataframe() #4333

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment