Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facetgrid: Ensure that colormap params are only determined once. #3915

Merged
merged 5 commits into from
Apr 11, 2020
Merged

facetgrid: Ensure that colormap params are only determined once. #3915

merged 5 commits into from
Apr 11, 2020

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Mar 29, 2020 •
edited
Loading

Not sure how to test this.

@dcherian
Copy link
Contributor Author

dcherian commented Apr 3, 2020

@mathause any thoughts on how we could test this?

@mathause
Copy link
Collaborator

mathause commented Apr 5, 2020

The MWE in #3569 throws an error after #3916 (ValueError("Cannot supply vmin and a norm with a different vmin.")) - maybe it is enough to test that it works again?

I reverted to before #3569 and tried to figure out the difference in the QuadContourSet in terms of norm and some other properties of h and facet._mappables[0] is and couldn't figure it out.

h = ds[0].plot.contour(levels=[4], colors=['k'])
facet = ds.plot.contour(col='time', levels=[4], colors=['k'])

dcherian added 3 commits April 5, 2020 07:43
@dcherian
Merge branch 'master' into facetgrid-cmap-params-once
2ad2183 
* master:
  Use divergent colormap if lowest and highest level span 0 (pydata#3913)
  Bugfix for plotting transposed 2d coords (pydata#3934)
  Allow plotting bool data (pydata#3766)
  facetgrid: fix case when vmin == vmax (pydata#3916)
  add a CI that tests xarray with all optional dependencies but dask (pydata#3919)
  Add missing_dims argument allowing isel() to ignore missing dimensions (pydata#3923)
  Only fail if a specific warning occurs (pydata#3930)
  Fix minor code quality issues (pydata#3626)
  Fix for stack+groupby+apply w/ non-increasing coord (pydata#3906)
  reactivate the macos CI (pydata#3920)
  add pint to the output of show_versions() (pydata#3918)
@dcherian
Add test
61833b9
@dcherian
update whats-new
f4323a8
@dcherian
Copy link
Contributor Author

dcherian commented Apr 5, 2020

The MWE in #3569 throws an error after #3916 (ValueError("Cannot supply vmin and a norm with a different vmin.")) - maybe it is enough to test that it works again?

Confirmed. I have added this as a test. Thanks.

I reverted to before #3569 and tried to figure out the difference in the QuadContourSet in terms of norm and some other properties of h and facet._mappables[0] is and couldn't figure it out.

Yes I could not figure what the difference was either...

@dcherian dcherian merged commit 2c77eb5 into pydata:master Apr 11, 2020
@dcherian dcherian deleted the facetgrid-cmap-params-once branch April 11, 2020 16:12
dcherian added a commit to dcherian/xarray that referenced this pull request May 1, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into map-blocks-schema
085ce9a 
* upstream/master: (39 commits)
  Pint support for DataArray (pydata#3643)
  Apply blackdoc to the documentation (pydata#4012)
  ensure Variable._repr_html_ works (pydata#3973)
  Fix handling of abbreviated units like msec (pydata#3998)
  full_like: error on non-scalar fill_value (pydata#3979)
  Fix some code quality and bug-risk issues (pydata#3999)
  DOC: add pandas.DataFrame.to_xarray (pydata#3994)
  Better chunking error messages for zarr backend (pydata#3983)
  Silence sphinx warnings (pydata#3990)
  Fix distributed tests on upstream-dev (pydata#3989)
  Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956)
  keep attrs in interpolate_na (pydata#3970)
  actually use preformatted text in the details summary (pydata#3978)
  facetgrid: Ensure that colormap params are only determined once. (pydata#3915)
  RasterioDeprecationWarning (pydata#3964)
  Empty line missing for DataArray.assign_coords doc (pydata#3963)
  New coords to existing dim (doc) (pydata#3958)
  implement a more threadsafe call to colorbar (pydata#3944)
  Fix wrong order of coordinate converted from pd.series with MultiIndex (pydata#3953)
  Updated list of core developers (pydata#3943)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drawing only one contour in FacetGrid
2 participants
@dcherian @mathause