Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix plot 2d coords transpose #3934

Merged
merged 4 commits into from
Apr 4, 2020
Merged

Bugfix plot 2d coords transpose #3934

merged 4 commits into from
Apr 4, 2020

Conversation

TomNicholas
Copy link
Member

Simple fix for #3933 - just required transposing y data before passing to matplotlib.

@TomNicholas TomNicholas mentioned this pull request Apr 4, 2020
Closed
@TomNicholas
Copy link
Member Author

(Test failure is because somehow conda failed while checking minimum versions)?

@TomNicholas TomNicholas requested a review from dcherian April 4, 2020 17:15
@keewis
Copy link
Collaborator

keewis commented Apr 4, 2020

yeah, that sometimes happens (I think the AttributeError indicates some kind of flaky bug in conda). We should be able to rerun the test to make it pass.

dcherian
dcherian approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomNicholas

@keewis
Copy link
Collaborator

keewis commented Apr 4, 2020

okay, rerunning the CI job worked.

Looks good to me, too. Should we merge this?

@TomNicholas
Copy link
Member Author

Approving review (thanks @dcherian ) so I will merge it

@TomNicholas TomNicholas merged commit 8d280cd into pydata:master Apr 4, 2020
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 5, 2020
@dcherian
Merge branch 'master' into facetgrid-cmap-params-once
2ad2183 
* master:
  Use divergent colormap if lowest and highest level span 0 (pydata#3913)
  Bugfix for plotting transposed 2d coords (pydata#3934)
  Allow plotting bool data (pydata#3766)
  facetgrid: fix case when vmin == vmax (pydata#3916)
  add a CI that tests xarray with all optional dependencies but dask (pydata#3919)
  Add missing_dims argument allowing isel() to ignore missing dimensions (pydata#3923)
  Only fail if a specific warning occurs (pydata#3930)
  Fix minor code quality issues (pydata#3626)
  Fix for stack+groupby+apply w/ non-increasing coord (pydata#3906)
  reactivate the macos CI (pydata#3920)
  add pint to the output of show_versions() (pydata#3918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot.line breaks depending on coordinate shape
3 participants
@TomNicholas @keewis @dcherian