Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve where docstring #3836

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Improve where docstring #3836

merged 5 commits into from
Mar 19, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Mar 6, 2020

  • Passes isort -rc . && black . && mypy . && flake8
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

The x, y doesn't carry over to the online docs: http://xarray.pydata.org/en/stable/generated/xarray.where.html#xarray.where, lmk if there's a hack for representing that in a better way

xarray/core/computation.py Outdated Show resolved Hide resolved
# Conflicts:
#	xarray/core/computation.py
This was referenced Mar 16, 2020
@max-sixty
Copy link
Collaborator Author

Ready

Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

Thanks @max-sixty

@max-sixty max-sixty merged commit 5548c1e into pydata:master Mar 19, 2020
@max-sixty max-sixty deleted the where-docstring branch March 19, 2020 21:30
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 22, 2020
* upstream/master:
  add spacing in the versions section of the issue report (pydata#3876)
  map_blocks: allow user function to add new unindexed dimension. (pydata#3817)
  Delete associated indexes when deleting coordinate variables. (pydata#3840)
  remove macos build while waiting for libwebp fix (pydata#3875)
  Fix html repr on non-str keys (pydata#3870)
  Allow ellipsis to be used in stack (pydata#3826)
  Improve where docstring (pydata#3836)
  Add DataArray.pad, Dataset.pad, Variable.pad (pydata#3596)
  Fix some warnings (pydata#3864)
  Feature/weighted (pydata#2922)
  Fix recombination in groupby when changing size along the grouped dimension (pydata#3807)
  Blacken the doctest code in docstrings (pydata#3857)
  Fix multi-index with categorical values. (pydata#3860)
  Fix interp bug when indexer shares coordinates with array (pydata#3758)
  Fix alignment with join="override" when some dims are unindexed (pydata#3839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants