Allow ellipsis to be used in stack #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Thanks @max-sixty. That was quick!
LGTM. We should add a sentence to the docstrings.
|
Should we support
Currently implemented for both but leaning towards the first, partly because it makes the typing correct |
|
Changed to supporting the first ( |
max-sixty
force-pushed
the
stack-ellipsis
branch
from
43aa4ec to
134db2d
Compare
|
This is very cool! It seems like it would be natural to support a combination of ellipsis and some explicit dimensions, like what can be done in transpose? E.g., |
Yes great! |
|
Updated! |
dcherian
reviewed
Mar 9, 2020
|
Thanks @max-sixty |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 22, 2020
* upstream/master: add spacing in the versions section of the issue report (pydata#3876) map_blocks: allow user function to add new unindexed dimension. (pydata#3817) Delete associated indexes when deleting coordinate variables. (pydata#3840) remove macos build while waiting for libwebp fix (pydata#3875) Fix html repr on non-str keys (pydata#3870) Allow ellipsis to be used in stack (pydata#3826) Improve where docstring (pydata#3836) Add DataArray.pad, Dataset.pad, Variable.pad (pydata#3596) Fix some warnings (pydata#3864) Feature/weighted (pydata#2922) Fix recombination in groupby when changing size along the grouped dimension (pydata#3807) Blacken the doctest code in docstrings (pydata#3857) Fix multi-index with categorical values. (pydata#3860) Fix interp bug when indexer shares coordinates with array (pydata#3758) Fix alignment with join="override" when some dims are unindexed (pydata#3839)
This was referenced Mar 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API