Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include tests in sdist #457

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Conversation

bollwyvl
Copy link
Collaborator

References

Changes

  • includes the tests in the .tar.gz
    • this will allow downstream package maintainers to confidently test the code when re-packaging
  • does not
    • include the tests in the whl
    • create an importable module called tests, which happens all over, because there is no tests/__init__.py

@choldgraf
Copy link
Collaborator

@bollwyvl what's the relationship between this and #393 ? Does this re-implement part of it? If so, I think we should merge this one quickly, and potentially close the other one since I think moving the tests to another folder warrants team discussion.

@bollwyvl
Copy link
Collaborator Author

This approach does exactly #453 and no more, while #393 would also include the tests in whls.

So this is probably preferable for most purposes:

  • downstreams get the tests (and then may choose to further distribute them, or not)
  • "nornal" pip usage keeps the same download profile, as the whl continues to not include the tests

@choldgraf
Copy link
Collaborator

woot - then let's 🚢 it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please package testsuite to the distribution tarball
2 participants