Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install pytest-codspeed on non x86_64 machines #895

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Aug 16, 2023

Change Summary

Should fix failures like https://github.com/pydantic/pydantic-core/actions/runs/5879887441/job/15946120306

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #895 (b597ca4) into main (e56491e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         105      105           
  Lines       15333    15333           
  Branches       25       25           
=======================================
  Hits        14374    14374           
  Misses        953      953           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56491e...b597ca4. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 16, 2023

CodSpeed Performance Report

Merging #895 will improve performances by 28.51%

Comparing dh/codspeed-limits (b597ca4) with main (e56491e)

Summary

🔥 1 improvements
✅ 137 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/codspeed-limits Change
🔥 test_dont_raise_error 38.9 µs 30.3 µs +28.51%

@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt davidhewitt merged commit b57f5fd into main Aug 16, 2023
29 of 30 checks passed
@davidhewitt davidhewitt deleted the dh/codspeed-limits branch August 16, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants