Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some missing pypy builds for macos #894

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Aug 16, 2023

Change Summary

Add pypy builds for arm macos, which is supported since PyPy 3.8.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Aug 16, 2023
@davidhewitt davidhewitt changed the title add some missing pypy builds for windows and macos add some missing pypy builds for macos Aug 16, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 16, 2023

CodSpeed Performance Report

Merging #894 will degrade performances by 12.34%

Comparing dh/macos-pypy-builds (9f6e5f9) with main (e56491e)

Summary

🔥 3 improvements
❌ 1 regressions
✅ 134 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/macos-pypy-builds Change
🔥 test_complete_core_lax 1.8 ms 1.3 ms +40.75%
🔥 test_set_of_ints_core_json_duplicates 5.5 ms 4.8 ms +13.07%
test_core_str 30.5 µs 34.8 µs -12.34%
🔥 test_dont_raise_error 38.9 µs 29.2 µs +33.13%

@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt
Copy link
Contributor Author

test failure looks unrelated and should be fixed by #895

@dmontagu dmontagu merged commit c2548a2 into main Aug 16, 2023
62 of 66 checks passed
@dmontagu dmontagu deleted the dh/macos-pypy-builds branch August 16, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants