Add instrument_sqlite3
#634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
Deploying logfire-docs with
|
| Latest commit: |
e0cd258
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fad89663.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-instrument-sqlite3.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 135 +2
Lines 10620 10682 +62
Branches 1461 1467 +6
=========================================
+ Hits 10620 10682 +62 ☔ View full report in Codecov by Sentry. |
alexmojaki
reviewed
Dec 2, 2024
| if conn is not None: | ||
| return SQLite3Instrumentor().instrument_connection(conn, tracer_provider=tracer_provider) # type: ignore[reportUnknownMemberType] | ||
| else: | ||
| return SQLite3Instrumentor().instrument(tracer_provider=tracer_provider, **kwargs) # type: ignore[reportUnknownMemberType] |
There was a problem hiding this comment.
Minor, but the other integrations intentionally make it possible to override tracer_provider in kwargs
There was a problem hiding this comment.
I've copied this implementation from mysql. 🤔
There was a problem hiding this comment.
but it's different in main.py:
return instrument_mysql(
conn=conn,
**{ # type: ignore
'tracer_provider': self._config.get_tracer_provider(),
'meter_provider': self._config.get_meter_provider(),
**kwargs,
},
)
1 task
alexmojaki
approved these changes
Dec 2, 2024
|
Thanks @alexmojaki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.