sqlite3 instrumentation support added
#255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Yes this would be appreciated. It'd also need docs. |
|
@deepakdinesh1123 Are you willing to resume your work on this PR? |
|
@Kludex No, I am busy at work so I have not been able to work on this. |
|
@deepakdinesh1123 I'll close this PR since you don't have time to finish. Let us know if you want to do it later. We'll be happy to help. :) |
|
We'll eventually implement this anyway. |
|
This is being done in #634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if this is something that you guys would like to add to logfire, I will add some more tests and make any changes that you guys suggest.
TODO