-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to SQLite3 #3057
Conversation
@Kludex CI is red, you have to use Tuple from typing I guess |
.../opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3/__init__.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3/__init__.py
Outdated
Show resolved
Hide resolved
When you use The problem was the |
Not sure about that:
|
I'm missing the future annotations on that file... |
...n/opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3/package.py
Outdated
Show resolved
Hide resolved
…telemetry/instrumentation/sqlite3/package.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex any chance you can fix the failing CI?
Head branch was pushed to by a user without write access
Let's try again.
Taking the opportunity to open this PR while working on pydantic/logfire#634.
cc @xrmx @emdneto