-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to #177 #198
Additions to #177 #198
Conversation
…ackets from plots as per SI standard, quick plot for varying length signals, add pybop.is_numeric and restore design cost exception for optimisation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 177-plotting-capabilities #198 +/- ##
=============================================================
- Coverage 94.61% 94.19% -0.43%
=============================================================
Files 35 36 +1
Lines 1857 1997 +140
=============================================================
+ Hits 1757 1881 +124
- Misses 100 116 +16 ☔ View full report in Codecov by Sentry. |
…y. Update tests, add base model classes to init, cleaner multi-signal interaction
…er tests, dict output observer.evaluate()
…version due to breaking change in 8.1.0
… Discharge capacity as default additional_variable
…icode, add infeasible unit test
Datatype restructure for optimisation objects
…ptimisers, pass optimiser final cost as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to merge once the coverage is passing, thanks very much @BradyPlanden!
This adds the following:
DEFAULT_SUBPLOT_TRACE_OPTIONS
variablepybop.is_numeric
function for checking input valuesEncompasses #224. This PR is also a step towards fixing our current failing scheduled tests.