Design Optimisation Refactor and Additions #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
- Coverage 94.58% 94.55% -0.04%
===========================================
Files 40 42 +2
Lines 1756 1783 +27
===========================================
+ Hits 1661 1686 +25
- Misses 95 97 +2 ☔ View full report in Codecov by Sentry. |
Closed
* Add intermediate model classes * Update spm_electrode_design.ipynb * Add test for GravimetricEnergyDensity * Update pybop/models/empirical/ecm_base.py Co-authored-by: Brady Planden <[email protected]> * Update pybop/models/lithium_ion/echem_base.py Co-authored-by: Brady Planden <[email protected]>
NicolaCourtier
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Great work incorporating design optimisation into the main functionality of PyBOP.
Ready to merge, thanks @BradyPlanden!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors:
Updates
quick_plottrace names dependent on problem definition.Closes #162