Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with PR #167 #186

Closed
NicolaCourtier opened this issue Feb 8, 2024 · 0 comments · Fixed by #183
Closed

Issue with PR #167 #186

NicolaCourtier opened this issue Feb 8, 2024 · 0 comments · Fixed by #183
Assignees

Comments

@NicolaCourtier
Copy link
Member

PR #167 moves the following functions required for design optimisation from an example script into _costs.py:

  • GravimetricEnergyDensity()
  • nominal_capacity()
  • cell_mass()

Conceptually the nominal capacity and the cell mass are part of the Model. This becomes clear when considering the definitions for electrochemical models vs. equivalent circuit models. Therefore these two functions should be moved to a base class for electrochemical models. This results in a useful change to the function call from nominal_capacity(x, model) to model.nominal_capacity(x). Also, when changed from a cost-specific function to a model function, we should change the name from "nominal" to "approximate" capacity because its definition can only be an approximation for the nominal capacity.

@NicolaCourtier NicolaCourtier self-assigned this Feb 8, 2024
@NicolaCourtier NicolaCourtier linked a pull request Feb 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant