-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[smart_holder] Add test_namespace_visibility #4050
[smart_holder] Add test_namespace_visibility #4050
Conversation
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests. (An earlier version of this code was used to inform PR pybind#4043.)
…eless diagnostics.
…and CUDA `test_cross_module_exception_translator` failures).
…s action un-helpfully removed the added noqa).
…files, only setting the module docstring and doing nothing else.
…py, so that it is imported by pytest before test_exceptions.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are all nit-picks so please ignore if you want.
tests/namespace_visibility.h
Outdated
@@ -0,0 +1,31 @@ | |||
// Copyright (c) 2022 The Pybind Development Team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a different extension.
I use .inc
for files that are not normal header files others use .inl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to .inl
:
pre-commit run --all-files clang-format
did not pick up the .inc
file, but it does pick up .inl
without any changes elsewhere.
(A also tested this Google-internally with .inl
and it worked immediately, too.)
Description
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests.
(An earlier version of this code was used to inform PR #4043.)
Suggested changelog entry: