PYBIND11_NAMESPACE consistency fixes.
#4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Jul 6, 2022
|
Thanks! |
|
Just to note, the one post-merge CI failure is a flake I saw several times before already. |
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Jul 8, 2022
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests. (An earlier version of this code was used to inform PR pybind#4043.)
|
Pure record keeping, JIC it's useful for something later: (For reasons that are difficult to explain) I compared
Due to the flake mentioned in my previous comment, one result is missing. Apart from that, the Dumping the current |
rwgk
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Add test_namespace_visibility To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests. (An earlier version of this code was used to inform PR #4043.) * Disable flake8 in ubench/holder_comparison_*.py, to suppress new & useless diagnostics. * Disable namespace_visibility_1s.cpp (tosee if that resolves the MSVC and CUDA `test_cross_module_exception_translator` failures). * Turn off flake8 completely for ubench (the Strip unnecessary `# noqa`s action un-helpfully removed the added noqa). * Disable test_namespace_visibility completely. Just keep the two .cpp files, only setting the module docstring and doing nothing else. * Rename test_namespace_visibility.py to test_exc_namespace_visibility.py, so that it is imported by pytest before test_exceptions.py * Add `set_property(SOURCE namespace_visibility_1s.cpp PROPERTY LANGUAGE CUDA)` * Add reference to PR #4054 * Complete the documentation (comments in test_exc_namespace_visibility.py). * Rename namespace_visibility.h to namespace_visibility.inl, as suggested by @charlesbeattie
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple long-standing
PYBIND11_NAMESPACE__attribute__((visibility("hidden")))inconsistencies. The fixes only affect builds with__GNUG__defined.Based on experiments under PR #4044, this (currently) only makes a difference in an unusual situation: macOS, NOT using
-fvisibility=hidden. However, if someone ventures there, surprises due to inconsistencies can be extremely time-consuming to troubleshoot.(Discovered while experimenting related to PR #4022.)
Suggested changelog entry: