-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve str exceptions and consistency with python #3826
fix: improve str exceptions and consistency with python #3826
Conversation
Why keep the macro? |
In case some third party caster uses it? I am fine with nuking them, but we should probably make a separate PR to nuke them all at once. |
I see at least a few users: https://cs.github.com/?scopeName=All+repos&scope=&q=PYBIND11_BYTES_AS_STRING_AND_SIZE Tencent/MMKV: POSIX/Python/libmmkv_python.cpp for example. |
(There are quite a lot of users of our compatibility macros overall - if we want to get rid of them, we need deprecation messages, etc.) |
Hurray for downstream users using undocumented internal macros! 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUCH better, thanks for cleaning this up Aaron!
Description
Suggested changelog entry: