Raise codec errors when casting to std::string #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
force-pushed
the
string_cast_unicode_error
branch
from
1b02928 to
e1abcb6
Compare
Allow the codec's exception to be raised instead of RuntimeError when casting from py::str to std::string. PY2 allows ucs surrogates in UTF-8 conversion Signed-off-by: Shane Loretz <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
sloretz
force-pushed
the
string_cast_unicode_error
branch
from
e1abcb6 to
8dd8461
Compare
Skylion007
approved these changes
Jul 13, 2021
|
Hi @Skylion007, consider this approved also by me, but ideally I'd run this through the Google-internal global testing (which includes testing a large number of open source packages) before merging. Is it OK with you to wait a few hours? In the past we had a couple cases with a surprising number of hiccups caused by similar changes. I feel this one will be fine, but good to be sure by testing first. |
|
@rwgk Sure, go ahead. |
rwgk
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the codec's exception to be raised instead of
RuntimeErrorwhen casting frompy::strtostd::string. I ran into this when porting a CPython extention to pybind11 with an existing test that expected aUnicodeEncodeErrorwhen given a string with UCS surrogate characters.Suggested changelog entry: