Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use CMAKE_INSTALL_FULL_INCLUDEDIR #3005

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

dotlambda
Copy link
Contributor

@dotlambda dotlambda commented May 14, 2021

Description

see https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path

Suggested changelog entry:

Fix ``pybind11_INCLUDE_DIR`` in case ``CMAKE_INSTALL_INCLUDEDIR`` is absolute

@dotlambda dotlambda requested a review from henryiii as a code owner May 14, 2021 11:03
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, and it available at least since 3.4 (only one I checked). Might need to look over that list and update https://cliutils.gitlab.io/modern-cmake/ .

@henryiii henryiii merged commit d00fc62 into pybind:master Jun 19, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 19, 2021
@dotlambda dotlambda deleted the patch-1 branch June 20, 2021 09:35
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants