Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect cmake install path in 2.7.0 release? #3136

Closed
stellaraccident opened this issue Jul 20, 2021 · 2 comments · Fixed by #3144
Closed

[BUG] Incorrect cmake install path in 2.7.0 release? #3136

stellaraccident opened this issue Jul 20, 2021 · 2 comments · Fixed by #3144

Comments

@stellaraccident
Copy link

I have a local requirements.txt file that just uses the latest pybind11 and when I rebuilt my environment, I got the 2.7.0 release, which looks new. However, CMake is detecting include and lib paths that look suspiciously like they are from the VM that built it, not the actual install location on my machine. Example CMake output:

-- found (/home/stella/src/iree-forge/build/iree-forge.venv/lib/python3.8/site-packages/pybind11/share/cmake/pybind11)
-- Found pybind11: /home/runner/work/pybind11/pybind11/pybind11/include (found version "2.7.0" )
-- Found pybind11 v2.7.0: /home/runner/work/pybind11/pybind11/pybind11/include

This was found while building the LLVM/MLIR python bindings from head with recommended instructions: https://mlir.llvm.org/docs/Bindings/Python/ (but I imagine there are easier ways to repro). I'm about to push a commit that excludes that version from our dev setup.

stellaraccident added a commit to llvm/llvm-project that referenced this issue Jul 20, 2021
Appears to have a broken CMake installation. Reported bug: pybind/pybind11#3136
@henryiii
Copy link
Collaborator

Verified, the generated Config file has set(pybind11_INCLUDE_DIR "/home/runner/work/pybind11/pybind11/pybind11/include") instead of a relative path.

@henryiii
Copy link
Collaborator

This was broken by #3005 - CMAKE_INSTALL_FULL_INCLUDEDIR is an absolute path so this breaks using this from the Python package.

arichardson pushed a commit to CTSRD-CHERI/llvm-project that referenced this issue Sep 29, 2021
Appears to have a broken CMake installation. Reported bug: pybind/pybind11#3136
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
Appears to have a broken CMake installation. Reported bug: pybind/pybind11#3136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants