#705 fix sign error #706
Merged
#705 fix sign error #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinsulzer
approved these changes
Nov 5, 2019
| @@ -461,6 +461,43 @@ def test_pure_neumann_poisson(self): | |||
| u_exact = z ** 2 / 2 - 1 / 6 | |||
| np.testing.assert_array_almost_equal(solution.y[:-1], u_exact, decimal=1) | |||
|
|
|||
| def test_dirichlet_bcs(self): | |||
| # manufactured solution u = a*z^2 + b*z + c | |||
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 176 176
Lines 9135 9135
=======================================
Hits 8968 8968
Misses 167 167
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a sign error when implementing Dirichlet BCs in the finite element method
EDIT: also fixes a bug where spatial variables were discretised to a vector of length N_y or N_z for y and z, respectively, instead of a vector of length N_y*N_z
Fixes #705
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: