Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign error in fem dirichlet bcs #705

Closed
rtimms opened this issue Nov 5, 2019 · 0 comments · Fixed by #706
Closed

sign error in fem dirichlet bcs #705

rtimms opened this issue Nov 5, 2019 · 0 comments · Fixed by #706
Assignees
@rtimms
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Nov 5, 2019

In FEM dirichlet BCs have the wrong sign
@rtimms rtimms added the bug Something isn't working label Nov 5, 2019
@rtimms rtimms self-assigned this Nov 5, 2019
rtimms added a commit that referenced this issue Nov 5, 2019
@rtimms
#705 fix sign error
3e11efe
@rtimms rtimms mentioned this issue Nov 5, 2019
Merged
8 tasks
rtimms added a commit that referenced this issue Nov 5, 2019
@rtimms
#705 changelog
e4cf50e
rtimms added a commit that referenced this issue Nov 6, 2019
@rtimms
#705 fix disc of spatial var
3a2c037
rtimms added a commit that referenced this issue Nov 6, 2019
@rtimms
#705 remove old spatial var disc
cb19c95
rtimms added a commit that referenced this issue Nov 6, 2019
@rtimms
Merge pull request #706 from pybamm-team/issue-705-fem-bc-bug
aba1aae 
#705 fix sign error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#705 fix sign error pybamm-team/PyBaMM
1 participant
@rtimms