-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 684 casadi events #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @tinosulzer. Well done getting this up and running. Looks like still getting some NaNs in the solution though. Maybe we can just remove those? A bit hacky though
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=========================================
Coverage ? 98.21%
=========================================
Files ? 176
Lines ? 9040
Branches ? 0
=========================================
Hits ? 8879
Misses ? 161
Partials ? 0
Continue to review full report at Codecov.
|
219abd9
to
f4bcce7
Compare
Description
Add 'safe' mode to casadi for solving with events. This is hacky and make the solver slower.
Fixes #684
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: