Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casadi events #684

Closed
valentinsulzer opened this issue Oct 26, 2019 · 0 comments · Fixed by #691
Closed

Casadi events #684

valentinsulzer opened this issue Oct 26, 2019 · 0 comments · Fixed by #691
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Hack events with the casadi solver by doing step-and-check (if possible). May slow down the solver too much.
@valentinsulzer valentinsulzer mentioned this issue Oct 26, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Oct 29, 2019
@valentinsulzer
#684 set up stepping
ec7e934
valentinsulzer added a commit that referenced this issue Oct 29, 2019
@valentinsulzer
#684 add events
3a28b08
valentinsulzer added a commit that referenced this issue Oct 30, 2019
@valentinsulzer
#684 fix tests, still need to do event termination
0115644
valentinsulzer added a commit that referenced this issue Oct 30, 2019
@valentinsulzer
#684 add termination reasons
d6a312f
@valentinsulzer valentinsulzer mentioned this issue Oct 30, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Oct 30, 2019
@valentinsulzer
#684 casadi
7da7d16
valentinsulzer added a commit that referenced this issue Oct 31, 2019
@valentinsulzer
#684 debugging example
2515a11
valentinsulzer added a commit that referenced this issue Oct 31, 2019
@valentinsulzer
#684 fix weird nans bug
41d1a73
valentinsulzer added a commit that referenced this issue Oct 31, 2019
@valentinsulzer
#684 move mode
ca8648c
valentinsulzer added a commit that referenced this issue Oct 31, 2019
@valentinsulzer
#684 remove valueerror
5a35536
valentinsulzer added a commit that referenced this issue Oct 31, 2019
@valentinsulzer
#684 flake8
219abd9
@valentinsulzer valentinsulzer self-assigned this Oct 31, 2019
valentinsulzer added a commit that referenced this issue Nov 1, 2019
@valentinsulzer
#684 flake8
551f625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 684 casadi events pybamm-team/PyBaMM
1 participant
@valentinsulzer